Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We must support API 33 from Aug 31 #4185

Merged
merged 1 commit into from
Aug 23, 2023
Merged

We must support API 33 from Aug 31 #4185

merged 1 commit into from
Aug 23, 2023

Conversation

andydotxyz
Copy link
Member

Should have been simple but another issue in the go mobile binary XML output took a while to resolve...

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz andydotxyz requested a review from Jacalz August 23, 2023 15:21
@coveralls
Copy link

Coverage Status

coverage: 65.298% (+0.009%) from 65.289% when pulling c6f3c6a on andydotxyz:fix/playstore33 into fce9486 on fyne-io:develop.

Jacalz
Jacalz approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have a way to test this but the code looks fine so approved

@andydotxyz andydotxyz merged commit 852632a into fyne-io:develop Aug 23, 2023
@andydotxyz andydotxyz deleted the fix/playstore33 branch August 23, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz